-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code coverage increase, and manual code trigger - src/flags.js #87
Open
mrahmed2026
wants to merge
10
commits into
CMU-17313Q:f24
Choose a base branch
from
mrahmed2026:flag_js_coverage_increase
base: f24
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Code coverage increase, and manual code trigger - src/flags.js #87
mrahmed2026
wants to merge
10
commits into
CMU-17313Q:f24
from
mrahmed2026:flag_js_coverage_increase
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10719743949Details
💛 - Coveralls |
mrahmed2026
changed the title
Flag js coverage increase
Code coverage increase, and manual code trigger - src/flags.js
Sep 5, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to increase the overall code coverage of this file.
83.26% Statements 408/490 67.34% Branches 165/245 82.69% Functions 86/104 83.87% Lines 390/465
85.3% Statements 418/490 71.02% Branches 174/245 84.61% Functions 88/104 86.02% Lines 400/465
This was indicated in the npm run test locally, and on the code coverage tool, and shown to Professor Eduardo as well.
Further, I addded a console log to the flag.js file and it was shown after i triggered the code, by flagging a blog post or annoucement.